Skip to content

Fix -Wundef/C4668 warnings #15853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2024
Merged

Fix -Wundef/C4668 warnings #15853

merged 2 commits into from
Sep 14, 2024

Conversation

petk
Copy link
Member

@petk petk commented Sep 12, 2024

  • ZTS is either undefined or defined (to 1)
  • PHP_WIN32 is either undefined or defined (to 1)

@petk
Fix -Wundef/C4668 warnings
6dd7532 
- ZTS is either undefined or defined (to 1)
- PHP_WIN32 is either undefined or defined (to 1)
cmb69
cmb69 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Maybe give the respective code owner some time to review.

Girgias
Girgias approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petk
Copy link
Member Author

petk commented Sep 14, 2024

I've appended another one: HAVE_LIBEDIT is also either undefined or defined to 1

So, I'm not sure we're still waiting here for the code owners to review this one or not, but merge coming up since this reduces now the -Wundef warnings back to only 12 (11 due to timelib and 1 due to YYDEBUG).

@petk petk merged commit 888eb37 into php:master Sep 14, 2024
8 of 10 checks passed
@petk petk deleted the patch-wundef branch September 14, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

@nielsdos nielsdos nielsdos approved these changes

@Girgias Girgias Girgias approved these changes

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Category: Engine Extension: ffi Extension: opcache Extension: readline Extension: xmlreader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petk @cmb69 @nielsdos @Girgias