Fix oss-fuzz #71382 #15854
Merged
Fix oss-fuzz #71382 #15854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZVAL_ARR() does not support immutable arrays as it incorrectly sets the IS_TYPE_REFCOUNTED flag. Using zend_array_new(0) instead, as it's a rare case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return value of
zho_build_properties_ex()is passed toZVAL_ARR(), which sets theIS_TYPE_REFCOUNTEDflag. Returning&zend_emtpy_arraywill crash later when trying to dtor the zval.I'm fixing this by returning
zend_new_array(0)instead of&zend_empty_array.An alternative was to make
ZVAL_ARR()aware of immutable arrays, likeZVAL_STR()is with interned strings, but I found no other problematic cases.