Skip to content

Sync exif dependency on mbstring extension as optional #16062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

petk
Copy link
Member

@petk petk commented Sep 25, 2024

When decoding multibyte data in EXIF tags, the mbstring extension needs to be enabled. In Autotools this is now synced with ZEND_MOD_OPTIONAL in the C code, and on Windows it is now also optional.

The required dependency on mbstring extension was removed via 755c2cd which made the mbstring extension optional dependency.

Documentation update: php/doc-en#3793

When decoding multibyte data in EXIF tags, the mbstring extension needs
to be enabled. In Autotools this is now synced with ZEND_MOD_OPTIONAL
in the C code, and on Windows it is now also optional.

The required dependency on mbstring extension was removed via
755c2cd which made the mbstring
extension optional dependency.
petk added a commit to petk/doc-en that referenced this pull request Sep 25, 2024
The required dependency on mbstring extension in exif was removed via
php/php-src@755c2cd which made the
mbstring extension optional dependency.

Update for the PHP build system:
php/php-src#16062
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you!

Girgias pushed a commit to php/doc-en that referenced this pull request Sep 25, 2024
The required dependency on mbstring extension in exif was removed via
php/php-src@755c2cd which made the
mbstring extension optional dependency.

Update for the PHP build system:
php/php-src#16062
@petk petk merged commit 9ee9c0e into php:master Sep 26, 2024
10 checks passed
@petk petk deleted the patch-1-exif-mbstring-dep branch September 26, 2024 07:54
jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Oct 1, 2024
When decoding multibyte data in EXIF tags, the mbstring extension needs
to be enabled. In Autotools this is now synced with ZEND_MOD_OPTIONAL
in the C code, and on Windows it is now also optional.

The required dependency on mbstring extension was removed via
755c2cd which made the mbstring
extension optional dependency.
zonuexe added a commit to zonuexe/doc-ja that referenced this pull request Oct 31, 2024
The required dependency on mbstring extension in exif was removed via
php/php-src@755c2cd which made the
mbstring extension optional dependency.

Update for the PHP build system:
php/php-src#16062

php/doc-en@c0af8c9
zonuexe added a commit to zonuexe/doc-ja that referenced this pull request Oct 31, 2024
The required dependency on mbstring extension in exif was removed via
php/php-src@755c2cd which made the
mbstring extension optional dependency.

Update for the PHP build system:
php/php-src#16062

php/doc-en@c0af8c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants