Skip to content

Allow to run push workflows manually #16148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Oct 1, 2024

As is, we're running the push workflow for all pushes and pull request, plus we run more comprehensive nightly workflow for all branches which had commits during the day. That means that security branches may not run CI for weeks or even months. In the meantime, dependencies might be updated, which can cause later workflow runs to fail. For instance, a few openssl tests fail due to security fixes in OpenSSL[1], an update of Oracle Instant Client causes a couple of oci8 and pdo_oci tests to fail[2], and the macOS builds do no longer even built (investigation pending).

Therefore, we allow to run the pull workflow manually, so it is possible to check the CI condition of temporary inactive branches from time to time.

[1] #16097
[2] #16107

As is, we're running the push workflow for all pushes and pull request,
plus we run more comprehensive nightly workflow for all branches which
had commits during the day.  That means that security branches may not
run CI for weeks or even months.  In the meantime, dependencies might
be updated, which can cause later workflow runs to fail.  For instance,
a few openssl tests fail due to security fixes in OpenSSL[1], an update
of Oracle Instant Client causes a couple of oci8 and pdo_oci tests to
fail[2], and the macOS builds do no longer even built (investigation
pending).

Therefore, we allow to run the pull workflow manually, so it is
possible to check the CI condition of temporary inactive branches from
time to time.

[1] <php#16097>
[2] <php#16107>
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. 🙂

@cmb69 cmb69 closed this in 0b5167c Oct 10, 2024
@cmb69 cmb69 deleted the cmb/push-workflow-dispatch branch October 10, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants