Check libavif API return values, if available #16434
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This went better than expected, and I don't want to trigger CI again, just for adding a commit message; this could be copied over from libgd/libgd#893. PS: nor do I want to change the target branch; should be applied to PHP-8.2, in my opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I consider not checking and handling these return values a bug (for builds against libavif >= 1.1.0, where the allocation routines do not longer abort on OOM conditions); thus this should target PHP-8.2. To check the FreeBSD builds, which uncovered this issue, I'm targeting PHP-8.4 for now.