Don't fiddle with NDEBUG in C code #16511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is way to late to do this in php.h, since assert.h has already been included. Even pushing that down to zend_portability.h may not have the desired effect. Instead we define or undefine NDEBUG as CFLAG, so that it works in all circumstances. As a last resort we fail at build time, if `NDEBUG` is defined when `ZEND_DEBUG` is enabled. We also remove the useless workaround in zend_test to include assert.h again, since that usually won't have any effect anyway.
|
Need to investigate the build failure for LINUX_X64_DEBUG_ZTS_ASAN. |
arnaud-lb
reviewed
Oct 21, 2024
Co-authored-by: Arnaud Le Blanc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is way to late to do this in php.h, since assert.h has already been included. Even pushing that down to zend_portability.h may not have the desired effect. Instead we define or undefine NDEBUG as CFLAG, so that it works in all circumstances.
As a last resort we fail at build time, if
NDEBUGis defined whenZEND_DEBUGis enabled.We also remove the useless workaround in zend_test to include assert.h again, since that usually won't have any effect anyway.
This is an alternative to #16366, which had been suggested by @arnaud-lb. I'm not quite sure whether this works well for phpize builds.
Also note that Windows (un)defines the
NDebugmacro; I have no idea what that is about.