fix compilation errors on Cygwin

[matyhtf]

compilation errors when using the --enable-opcache, --disable-opcache-jit, and --enable-zts configure options on Cygwin.

The tsrm_get_ls_cache_tcb_offset function is used exclusively in JIT. When JIT is disabled, this function should also be disabled.

Error

/usr/lib/gcc/x86_64-pc-cygwin/12/../../../../x86_64-pc-cygwin/bin/ld: warning: --export-dynamic is not supported for PE+ targets, did you mean --export-all-symbols?
/usr/lib/gcc/x86_64-pc-cygwin/12/../../../../x86_64-pc-cygwin/bin/ld: TSRM/TSRM.o: in function `tsrm_get_ls_cache_tcb_offset':
/cygdrive/d/a/swoole-cli/swoole-cli/TSRM/TSRM.c:769:(.text+0xc23): undefined reference to `_tsrm_ls_cache@gottpoff'
collect2: error: ld returned 1 exit status
make: *** [Makefile:291: bin/swoole-cli] Error 1

[cmb69]

This doesn't look right. A proper fix would likely be something like 4bb0dd4. Maybe

 TSRM/TSRM.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/TSRM/TSRM.c b/TSRM/TSRM.c
index 81136bee4d..e99993204b 100644
--- a/TSRM/TSRM.c
+++ b/TSRM/TSRM.c
@@ -778,7 +778,7 @@ TSRM_API size_t tsrm_get_ls_cache_tcb_offset(void)
 	return 0;
 #elif defined(__x86_64__) && defined(__GNUC__) && !defined(__FreeBSD__) && \
 	!defined(__NetBSD__) && !defined(__OpenBSD__) && !defined(__MUSL__) && \
-	!defined(__HAIKU__)
+	!defined(__HAIKU__) && !defined(__CYGWIN__)
 	size_t ret;
 
 	asm ("movq _tsrm_ls_cache@gottpoff(%%rip),%0"
@@ -786,7 +786,7 @@ TSRM_API size_t tsrm_get_ls_cache_tcb_offset(void)
 	return ret;
 #elif defined(__i386__) && defined(__GNUC__) && !defined(__FreeBSD__) && \
 	!defined(__NetBSD__) && !defined(__OpenBSD__) && !defined(__MUSL__) && \
-	!defined(__HAIKU__)
+	!defined(__HAIKU__) && !defined(__CYGWIN__)
 	size_t ret;
 
 	asm ("leal _tsrm_ls_cache@ntpoff,%0"

Note that I do not have a Cygwin environment set up.

cc @devnexen

[devnexen]

@cmb69 fix looks good to me would it be possible for you to test it locally @matyhtf ?

[jingjingxyk]

  sed -i.backup 's/!defined(__HAIKU__)/!defined(__HAIKU__) \&\& !defined(__CYGWIN__)/' TSRM/TSRM.c

[cmb69]

Can anybody confirm that the patch from #16568 (review) actually works for Cygwin builds?

[devnexen]

If nobody is into it, I ll try to install cygwin in my windows laptop and gives it a go tonight.

[jingjingxyk]

Can anybody confirm that the patch from #16568 (review) actually works for Cygwin builds?

It's work !

before : https://github.com/jingjingxyk/swoole-cli/actions/runs/11991949899/job/33431193604

after: https://github.com/swoole/swoole-cli/actions/runs/11992855971/job/33433194582

build script:
https://github.com/swoole/swoole-cli/blob/build_native_php/sapi/scripts/cygwin/cygwin-config.sh#L41
https://github.com/swoole/swoole-cli/blob/build_native_php/sapi/scripts/cygwin/cygwin-config-ext.sh
https://github.com/swoole/swoole-cli/blob/build_native_php/sapi/scripts/cygwin/cygwin-config.sh
https://github.com/swoole/swoole-cli/blob/build_native_php/sapi/scripts/cygwin/cygwin-build.sh

[cmb69]

See #16920. I think we can close this PR.

[cmb69]

The actual problem with this patch is that you can no longer build OPcache/JIT via phpize, because then tsrm_get_ls_cache_tcb_offset() would not be available. I'm not sure how to properly solve the build error, but I'm closing this PR in favor of #16920.