Add ReflectionConstant::getExtension() and ::getExtensionName()

[DanielEScherzer]

No description provided.

[nielsdos]

In favor.
I'm just not sure we need both a getExtension and getExtensionName method as we can trivially get the name from a ReflectionExtension with only a few extra keystrokes.
I'm also not too sure about the string|false return.

[DanielEScherzer]

In favor. I'm just not sure we need both a getExtension and getExtensionName method as we can trivially get the name from a ReflectionExtension with only a few extra keystrokes. I'm also not too sure about the string|false return.

I have no problem removing the name getter, but the request at #16571 included it noting that there is both a getExtension() and getExtensionName() for ReflectionClass and ReflectionFunction, so only having one of them might be a bit odd. Perhaps the getExtensionName() methods on the others should be deprecated?

[nielsdos]

No this PR is fine. It's more important to be consistent with what we have; even if it's a bit odd.
I wouldn't want to deprecate those as it doesn't cause harm.

[nielsdos]

Nice work, only 2 nits.

[nielsdos]

Seems fine to me, but let's wait a bit for others to chime in

[nielsdos]

No reaction yet; perhaps shoot a quick email to the mailing list with a link to this PR to see if anyone objects. If no one complains we can just merge it.

[Girgias]

LGTM, looks like an oversight

[DanielEScherzer]

<rebased, conflicts with #15847>

[nielsdos]

No one complained, I'm merging this.

[nielsdos]

Thanks!