-
Notifications
You must be signed in to change notification settings - Fork 7.9k
ext/pdo: Fixed memory leak of setFetchMode()
#16703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9c619a8
to
336d64c
Compare
CI is red, I'll fix it |
336d64c
to
67bc52e
Compare
Co-authored-by: Christoph M. Becker <[email protected]>
43740ff
to
6ab32fe
Compare
CI is green! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This looks good to me.
Thanks, maybe RMs seems to be working on packaging now, so I'll merge it tomorrow :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
* PHP-8.2: Added gc_handler to properly handle circular references. (#16703)
* PHP-8.3: Added gc_handler to properly handle circular references. (#16703)
* PHP-8.4: Added gc_handler to properly handle circular references. (#16703)
Opened the PR :)
@nielsdos @cmb69