Skip tests if ldap_set_rebind_proc() is not available #16708
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already done by ldap_set_rebind_proc_error.phpt, but not by the other two affected tests.
devnexen
approved these changes
Nov 7, 2024
For no particular reason. Applied to PHP-8.2 and merged up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already done by ldap_set_rebind_proc_error.phpt, but not by the other two affected tests.
Note that while ldap_set_rebind_proc_error.phpt has this check right, it, the check for the server being available is borked, because it mixes URI and hostname.
php-src/ext/ldap/tests/connect.inc
Line 10 in 228c271