Only patch libcurl.pc if it exists #16785
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, the problem is likely that |
|
Okay, the configuration passes now, but it fails to build because ICU has been updated to 76.1 in the meantime. Two weeks ago it was on 74.2. As of ICU 75.1 C++17 is required. Not sure what to do here. Ah, would need to backport Lines 84 to 91 in 45487c6 Should probably fix the version, though. Anyhow, I'm going to apply this now, since the two issues are unrelated. Can also see whether PHP-8.2 and PHP-8.3 get green. |
|
Oh, need to backport fixes for the new ICU version, too: https://github.com/php/php-src/actions/runs/11825254796/job/32948611602#step:8:373 PS: #16788 |
Hmm, probably not. Can we lock ICU to 74.2? PS: #16789. |
ericmann
pushed a commit
that referenced
this pull request
Nov 19, 2024
This is only defined as of PHP-8.4; alternatively we could also inline the `brew --prefix` call, but that makes it harder for upward merges. Closes GH-16785.
adoy
pushed a commit
that referenced
this pull request
Nov 19, 2024
This is only defined as of PHP-8.4; alternatively we could also inline the `brew --prefix` call, but that makes it harder for upward merges. Closes GH-16785.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #16783, because of https://github.com/php/php-src/actions/runs/11823721167/job/32943620474#step:5:98. Apparently, the homegrew people ship curl 8.11.0_1 now, and the .pc is gone (moved, removed, I don't know). Let's see.