Fix GH-17162: zend_array_try_init() with dtor can cause engine UAF #17167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
approved these changes
Dec 15, 2024
Zend/tests/gh17162.phpt
Outdated
| $box->value = null; | ||
| } | ||
| } | ||
| $box = new stdClass(); |
There was a problem hiding this comment.
Nit: I don't think this stdClass is needed? Technically it should be an array, should have the same result. This doesn't fail because $image_info only has a doc-block type.
There was a problem hiding this comment.
Yeah fair, forgot this when I changed it from an mbstring function to this one, I'll change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destructor can change the object and cause a UAF. We make the object inaccessible prior to destruction such that it is protected against the overwrite. This is also consistent with the behaviour if we were to comment out the call to
getimagesize().