Skip to content

Make build command for program using embed portable #17247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make build command for program using embed portable #17247

wants to merge 1 commit into from

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Dec 23, 2024

The = is a GNUism. It fails on Mac because it isn't supported by the clang linker (which is used even with GCC):

clang: error: linker command failed with exit code 1 (use -v to see invocation)

I also changed gcc to cc for maximum portability.

nielsdos
nielsdos approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is right, thanks

@nielsdos nielsdos closed this in a24eada Dec 24, 2024
charmitro pushed a commit to wasix-org/php that referenced this pull request Mar 13, 2025
@dunglas @charmitro
[ci skip] Make build command for program using embed portable
c368a5b 
Closes phpGH-17247.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dunglas @nielsdos