Implement slow GD test helpers in C #17305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two test helpers which need to traverse all pixels of the given images, what is obviously rather slow in PHP. To avoid that performance penalty, we implement the functions in C and make them available as internal PHP functions, but only if `GD_TEST_HELPERS` is defined when building. We still keep the PHP implementations as fall- back in case someone wants to run the tests without the internal functions being defined. We also improve the userland functions by traversing the pixels in Z order what is more cache efficient for the libgd implementation.
Closed
|
No, this doesn't make sense. At best, we can save a couple of seconds for "normal" test runs (assuming we do some performance optimization on the userland test helpers; I'll follow up on that soon), and that doesn't outweigh the cost of having to maintain two sets of test helpers. |
|
Maybe #14914 would be helpful. I'd be happy to rework it. |
|
@thg2k, possibly. However, it is not clear what exactly we should expose to userland (discussion apparently went nowhere), and it is indeed hard to come up with a general solution. I'll try to have a closer look at #14914 and #14877 and the related discussions (https://externals.io/message/124306 and https://externals.io/message/124383, respectively). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two test helpers which need to traverse all pixels of the given images, what is obviously rather slow in PHP. To avoid that performance penalty, we implement the functions in C and make them available as internal PHP functions, but only if
GD_TEST_HELPERSis defined when building. We still keep the PHP implementations as fall- back in case someone wants to run the tests without the internal functions being defined.We also improve the userland functions by traversing the pixels in Z order what is more cache efficient for the libgd implementation.
TODO:
gd_test_