Skip to content

skip new test when offline #17313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

remicollet
Copy link
Member

Failing in offline build

001- resource(%d) of type (stream)
001+ Warning: fopen(): php_network_getaddresses: getaddrinfo for www.example.com failed: Temporary failure in name resolution in /builddir/build/BUILD/php84-php-8.4.3_RC1-build/php-8.4.3RC1/ext/standard/tests/http/gh16810.php on line 9
002+ 
003+ Warning: fopen(http://www.example.com): Failed to open stream: php_network_getaddresses: getaddrinfo for www.example.com failed: Temporary failure in name resolution in /builddir/build/BUILD/php84-php-8.4.3_RC1-build/php-8.4.3RC1/ext/standard/tests/http/gh16810.php on line 9
004+ bool(false)
     
     Warning: fopen(http://www.example.com): Failed to open stream: timeout must be lower than %d in %s on line %d
     bool(false)

ping @devnexen (as added by you)

@remicollet remicollet requested a review from bukka as a code owner January 1, 2025 08:04
@remicollet remicollet requested review from devnexen and removed request for bukka January 1, 2025 08:04
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bukka
Copy link
Member

bukka commented Jan 1, 2025

I'm really sorry for such a bad review in #16810 . I should have blocked it. We really need to stop adding those online test. We have got either http server or openssl client server that can be used for those cases. We really need to get rid of online tests as they are completely useless.

@bukka
Copy link
Member

bukka commented Jan 1, 2025

@remicollet this should target 8.2 - we are backporting tests to security branches - it's frozen only for code bug fixes.

@bukka
Copy link
Member

bukka commented Jan 1, 2025

Ah sorry it was merged to 8.3 only (got confused by target branch in the PR)

@bukka
Copy link
Member

bukka commented Jan 1, 2025

Closing in favour of #17314 that changes the test to not be online.

@bukka bukka closed this Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants