Skip to content

Port clip_1d() clipping rectangle improvement of libgd 2.0.26 #17341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jan 3, 2025

This is not a functional change, but rather a performance improvement, to avoid unnecessary calls of gdImageSetPixel() which would be no-ops due to positions outside of the clipping bounds.

This is not a functional change, but rather a performance improvement,
to avoid unnecessary calls of `gdImageSetPixel()` which would be no-ops
due to positions outside of the clipping bounds.
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers

@cmb69 cmb69 merged commit 8a0b617 into php:master Jan 3, 2025
10 checks passed
@cmb69 cmb69 deleted the cmb/clip_1d branch January 3, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants