zend_ast: Print placeholder value when printing ZEND_AST_OP_ARRAY
#17405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the discussion in phpGH-17120, we are printing a placeholder value only. The commit history of that PR also includes alternative implementations, should a different decision be desirable. Fixes phpGH-17096 Closes phpGH-17120
iluuu1994
approved these changes
Jan 9, 2025
| @@ -1885,6 +1885,11 @@ static ZEND_COLD void zend_ast_export_ex(smart_str *str, zend_ast *ast, int prio | |||
| smart_str_appendl(str, ZSTR_VAL(name), ZSTR_LEN(name)); | |||
| break; | |||
| } | |||
| case ZEND_AST_OP_ARRAY: | |||
| smart_str_appends(str, "Closure("); | |||
There was a problem hiding this comment.
The format looks a bit non-standard, but I don't have a better suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in GH-17120, we are printing a placeholder value only. The commit history of that PR also includes alternative implementations, should a different decision be desirable.
Fixes GH-17096
Closes GH-17120