ext/mysqli: Use tempnam to make tracefiles unique #17473
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While a CONFLICTS acts as a barrier currently, it'd be nice to remove that. In addition, if multiple users run the test on the same system, it'd be owned by one user if a cleanup isn't run properly. The right solution for temporary files is tempnam and friends instead to generate a unique filename per invocation. mysqli_debug_ini.phpt is not yet treated with this, because it uses an --INI-- section instead; generating a unique name here is trickier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While a CONFLICTS acts as a barrier currently, it'd be nice to remove that. In addition, if multiple users run the test on the same system, it'd be owned by one user if a cleanup isn't run properly. The right solution for temporary files is tempnam and friends instead to generate a unique filename per invocation.
mysqli_debug_ini.phpt is not yet treated with this, because it uses an --INI-- section instead; generating a unique name here is trickier.