Fixed pdo_firebird_handle_factory to check ret when starting a transaction
#17632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to not execute php_firebird_begin_transaction if transaction cannot be started successfully
cmb69
approved these changes
Jan 30, 2025
|
@SakiTakamachi Forgot to merge this PR? Also please make the commit title more descriptive. |
|
Ahhhhh, yes, I forgot |
SakiTakamachi
changed the title
pdo_firebird_handle_factorypdo_firebird_handle_factory to check ret when starting a transaction
|
@nielsdos |
nielsdos
approved these changes
Mar 14, 2025
SakiTakamachi
added a commit
that referenced
this pull request
Mar 14, 2025
* PHP-8.4: Fixed pdo_firebird_handle_factory to check ret when starting a transaction (#17632)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to not execute php_firebird_begin_transaction if transaction cannot be started successfully