Skip to content

Fix GH-17704: ldap_search fails when $attributes contains a non-packed array with numerical keys #17710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Feb 5, 2025

No description provided.

@@ -248,7 +248,7 @@ static bool php_ldap_is_numerically_indexed_array(zend_array *arr)
}
} ZEND_HASH_FOREACH_END();

return false;
return true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that s unfortunate !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet this happened during the downwards merge. This was fixed first in master, and then needed a slightly different patch on 8.3-8.4. It's right on master but wrong on 8.3-8.4, so something must've gone wrong while merging

@nielsdos nielsdos marked this pull request as ready for review February 5, 2025 22:15
@nielsdos nielsdos closed this in 2fb88b2 Feb 6, 2025
charmitro pushed a commit to wasix-org/php that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ldap_search fails when $attributes contains a non-packed array with numerical keys
2 participants