Skip to content

Free the trampoline when deprecation on materializing __callStatic() of trait throws #17729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Feb 7, 2025

Fixes #17728

Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@TimWolla
Copy link
Member Author

TimWolla commented Feb 7, 2025

Not adding a NEWS entry, because this should not be observable on release builds.

@TimWolla TimWolla merged commit 00d4390 into php:PHP-8.3 Feb 7, 2025
9 checks passed
TimWolla added a commit that referenced this pull request Feb 7, 2025
* PHP-8.3:
  Free the trampoline when deprecation on materializing `__callStatic()` of trait throws (#17729)
TimWolla added a commit to TimWolla/php-src that referenced this pull request Feb 7, 2025
* PHP-8.4:
  Free the trampoline when deprecation on materializing `__callStatic()` of trait throws (php#17729)
@TimWolla TimWolla deleted the trait-magic-call-deprecation-throw branch February 7, 2025 09:54
charmitro pushed a commit to wasix-org/php that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants