Skip to content

ext/pdo: Use zend_strpprintf() instead of spprintf() #17743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2025
Merged

ext/pdo: Use zend_strpprintf() instead of spprintf() #17743

merged 1 commit into from
Feb 8, 2025

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Feb 8, 2025

Most of the time this will end up as a zend_string in some way anyway, do it directly.

@Girgias
ext/pdo: Use zend_strpprintf() instead of spprintf()
1b6bf0a 
Most of the time this will end up as a zend_string in some way anyway, do it directly.
@Girgias Girgias requested a review from nielsdos February 8, 2025 19:28
nielsdos
nielsdos approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, should avoid some copies.
Not that this is particularly hot code, but a welcome change nevertheless.

@Girgias Girgias merged commit 1331a61 into php:master Feb 8, 2025
9 checks passed
@Girgias Girgias deleted the pdo-strpprintf-usage branch February 8, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

Assignees
No one assigned
Labels
Extension: pdo (core)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @nielsdos