Skip to content

Change openssl_x509_verify test to use cert generator #17882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Change openssl_x509_verify test to use cert generator #17882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 53 additions & 34 deletions ext/openssl/tests/CertificateGenerator.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,33 @@ class CertificateGenerator
{
const CONFIG = __DIR__. DIRECTORY_SEPARATOR . 'openssl.cnf';

/** @var OpenSSLCertificate */
private $ca;
/** @var OpenSSLCertificate|false */
private $ca = false;

/** @var resource */
private $caKey;
/** @var OpenSSLAsymmetricKey|false */
private $caKey = false;

/** @var resource|null */
/** @var bool */
private $useSelfSignedCert;

/** @var OpenSSLCertificate|null */
private $lastCert;

/** @var resource|null */
/** @var OpenSSLAsymmetricKey|null */
private $lastKey;

public function __construct()
public function __construct(bool $useSelfSignedCert = false)
{
if (!extension_loaded('openssl')) {
throw new RuntimeException(
'openssl extension must be loaded to generate certificates'
);
}
$this->generateCa();
$this->useSelfSignedCert = $useSelfSignedCert;

if (!$this->useSelfSignedCert) {
$this->generateCa();
}
}

/**
Expand Down Expand Up @@ -54,40 +61,32 @@ class CertificateGenerator
'commonName' => 'CA for PHP Tests'
];

$this->ca = openssl_csr_sign(
openssl_csr_new(
$dn,
$this->caKey,
[
'x509_extensions' => 'v3_ca',
'config' => self::CONFIG,
]
),
null,
$this->caKey,
2,
[
'config' => self::CONFIG,
]
);
$csr = openssl_csr_new($dn, $this->caKey, ['config' => self::CONFIG]);
$this->ca = openssl_csr_sign($csr, null, $this->caKey, 365, ['config' => self::CONFIG]);
}

public function getCaCert()
{
if ($this->useSelfSignedCert) {
throw new RuntimeException("CA is not generated in self-signed mode.");
}

$output = '';
openssl_x509_export($this->ca, $output);

return $output;
}

public function saveCaCert($file)
{
if ($this->useSelfSignedCert) {
throw new RuntimeException("CA is not available in self-signed mode.");
}

openssl_x509_export_to_file($this->ca, $file);
}

private function generateCertAndKey(
$commonNameForCert, $file, $keyLength = null, $subjectAltName = null
) {
private function generateCertAndKey($commonNameForCert, $file, $keyLength = null, $subjectAltName = null)
{
$dn = [
'countryName' => 'BY',
'stateOrProvinceName' => 'Minsk',
Expand All @@ -98,8 +97,7 @@ class CertificateGenerator
$dn['commonName'] = $commonNameForCert;
}

$subjectAltNameConfig =
$subjectAltName ? "subjectAltName = $subjectAltName" : "";
$subjectAltNameConfig = $subjectAltName ? "subjectAltName = $subjectAltName" : "";
$configCode = <<<CONFIG
[ req ]
distinguished_name = req_distinguished_name
Expand Down Expand Up @@ -128,12 +126,17 @@ CONFIG;

$this->lastKey = self::generateKey($keyLength);
$csr = openssl_csr_new($dn, $this->lastKey, $config);

// If in self-signed mode, sign with the same key, otherwise use CA
$signingCert = $this->useSelfSignedCert ? null : $this->ca;
$signingKey = $this->useSelfSignedCert ? $this->lastKey : $this->caKey;

$this->lastCert = openssl_csr_sign(
$csr,
$this->ca,
$this->caKey,
/* days */ 2,
$config,
$signingCert,
$signingKey,
365, // 1 year validity
$config
);

return $config;
Expand Down Expand Up @@ -166,6 +169,22 @@ CONFIG;
unlink($config['config']);
}

public function saveNewCertAndPubKey(
$commonNameForCert, $certFile, $pubKeyFile, $keyLength = null, $subjectAltName = null
) {
$config = $this->generateCertAndKey($commonNameForCert, $certFile, $keyLength, $subjectAltName);

openssl_x509_export_to_file($this->lastCert, $certFile);

$keyDetails = openssl_pkey_get_details($this->lastKey);
if ($keyDetails === false || !isset($keyDetails['key'])) {
throw new RuntimeException("Failed to extract public key.");
}

file_put_contents($pubKeyFile, $keyDetails['key']);
unlink($config['config']);
}

public function getCertDigest($algo)
{
return openssl_x509_fingerprint($this->lastCert, $algo);
Expand Down
21 changes: 17 additions & 4 deletions ext/openssl/tests/openssl_x509_verify.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,24 @@ openssl_x509_verify() tests
openssl
--FILE--
<?php
$fp = fopen(__DIR__ . "/cert.crt","r");

$certFile = __DIR__ . '/openssl-x509-verify-cert.pem.tmp';
$keyFile = __DIR__ . '/openssl-x509-verify-key.pem.tmp';

include 'CertificateGenerator.inc';
$certificateGenerator = new CertificateGenerator(true);
$certificateGenerator->saveNewCertAndPubKey('openssl-x509-verify-server', $certFile, $keyFile);

$fp = fopen($certFile,"r");
$a = fread($fp, 8192);
fclose($fp);

$fp = fopen(__DIR__ . "/public.key","r");
$fp = fopen($keyFile,"r");
$b = fread($fp, 8192);
fclose($fp);

$cert = "file://" . __DIR__ . "/cert.crt";
$key = "file://" . __DIR__ . "/public.key";
$cert = "file://" . $certFile;
$key = "file://" . $keyFile;
$wrongKey = "file://" . __DIR__ . "/public_rsa_2048.key";

var_dump(openssl_x509_verify($cert, $key));
Expand All @@ -23,6 +31,11 @@ var_dump(openssl_x509_verify("", ""));
var_dump(openssl_x509_verify(openssl_x509_read($a), $b));
var_dump(openssl_x509_verify($cert, $wrongKey));
?>
--CLEAN--
<?php
@unlink(__DIR__ . '/openssl-x509-verify-cert.pem.tmp');
@unlink(__DIR__ . '/openssl-x509-verify-key.pem.tmp');
?>
--EXPECT--
int(1)
int(-1)
Expand Down
Loading