Skip to content

Fix skipped lazy init on primed SIMPLE_WRITE #17999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix skipped lazy init on primed SIMPLE_WRITE #17999

wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

@iluuu1994 iluuu1994 commented Mar 7, 2025 •
edited
Loading

Go through the normal assignment path, which includes an IS_UNDEF check.

Fixes GH-17998

@iluuu1994
Fix skipped lazy init on primed SIMPLE_WRITE
8acac6c 
Go through the normal assignment path, which includes an IS_UNDEF check.

Fixes phpGH-17998
@iluuu1994 iluuu1994 requested a review from arnaud-lb March 7, 2025 21:37
arnaud-lb
arnaud-lb approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@iluuu1994 iluuu1994 closed this in 9acfe6e Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov will be requested when the pull request is marked ready for review dstogov is a code owner

Assignees
No one assigned
Labels
ABI break Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iluuu1994 @arnaud-lb