Skip to content

Patch run tests from git work tree #18286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −1,000,000
Open

Patch run tests from git work tree #18286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab55e41
Sort skipped extensions in test summary
hakre Mar 10, 2025
2283755
Untrack test generated .data file
hakre Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,6 @@

# Vendored libraries
/ext/dom/lexbor/lexbor linguist-vendored

# Test data files
**/tests/**/*.data binary
Comment on lines +34 to +36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably not be in both .gitignore and .gitattributes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? @TimWolla

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitattributes applies to committed files, where-as .gitignore prevents files from being committed. So either of those is redundant (or should be more specific, or should have exclusions).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not true, .gitattributes are similar as .gitignores for the worktree as well.

And actually, that's the reason I put it there because the binary macro has -diff and diffing caused an issue resolving this. Therefore I added it.

Nevertheless, if there are still doubts about it, I can (happily!) split this PR and move it out. No need to rush the by-catch IMHO. Let me know and thanks for your feedback so far!

1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ php

# Generated by some test cases
**/tests/**/*.db
**/tests/**/*.data

# Microsoft Access database created for passing to tests
/ext/pdo_odbc/tests/*.mdb
Expand Down
Loading
Loading