Skip to content

Fix DOM tests for upcoming libxml2 serializer changes #18406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix DOM tests for upcoming libxml2 serializer changes #18406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ext/dom/tests/DOMElement_toggleAttribute.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,18 +87,18 @@ echo "Checking toggled namespace:\n";
var_dump($dom->documentElement->getAttribute('xmlns:anotheron'));

?>
--EXPECT--
--EXPECTF--
Invalid Character Error
--- Selected attribute tests (HTML) ---
bool(false)
<!DOCTYPE HTML>
<html id="test"></html>
bool(true)
<!DOCTYPE HTML>
<html id="test" selected></html>
<html id="test" selected%r(="")?%r></html>
bool(true)
<!DOCTYPE HTML>
<html id="test" selected></html>
<html id="test" selected%r(="")?%r></html>
bool(false)
<!DOCTYPE HTML>
<html id="test"></html>
Expand Down
6 changes: 3 additions & 3 deletions ext/dom/tests/gh10234.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ $document->documentElement->textContent = "quote 'test'";
var_dump($document->documentElement->textContent);
var_dump($document->saveHTML());
?>
--EXPECT--
--EXPECTF--
-- Attribute tests --
string(38) "<element attribute="value"></element>
"
Expand All @@ -67,10 +67,10 @@ string(13) "hello & world"
string(50) "<element attribute="hello &amp; world"></element>
"
string(9) "<b>hi</b>"
string(54) "<element attribute="&lt;b&gt;hi&lt;/b&gt;"></element>
string(%d) "<element attribute=%r("&lt;b&gt;hi&lt;\/b&gt;"|"<b>hi<\/b>")%r></element>
"
string(12) "quote "test""
string(45) "<element attribute='quote "test"'></element>
string(%d) "<element attribute=%r('quote "test"'|"quote &quot;test&quot;")%r></element>
"
string(12) "quote 'test'"
string(45) "<element attribute="quote 'test'"></element>
Expand Down
Loading