Skip to content

allow ldap_get_option to retrieve global option #18561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

allow ldap_get_option to retrieve global option #18561

wants to merge 2 commits into from

Conversation

remicollet
Copy link
Member

@remicollet remicollet commented May 15, 2025 •
edited
Loading

Allow NULL for LDAP\Connection for global options retrival
This makes ldap_get_option consistent with ldap_set_option

Also add more ldaps/tls tests with TLS_CACERTFILE
to improve coverage after #18529

@remicollet remicollet mentioned this pull request May 15, 2025
Closed
@remicollet remicollet marked this pull request as ready for review May 15, 2025 08:43
@remicollet remicollet requested a review from kocsismate as a code owner May 15, 2025 08:43
@remicollet
Copy link
Member Author

Notice: type widening is probably not a breaking change for a simple function

Girgias
Girgias approved these changes May 19, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but MSTM. Do not forget to update UPGRADING

ext/ldap/tests/ldap_start_tls_basic2.phpt Outdated
Comment on lines 3 to 5
--CREDITS--
Patrick Allaert <[email protected]>
# Belgian PHP Testfest 2009
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to remove this CREDITS section

@remicollet remicollet force-pushed the issue-ldapglobalopt branch from c3e12aa to fdc945b Compare May 19, 2025 05:33
@remicollet
Copy link
Member Author

Thanks for the review

Merged as 1e6909d e726d91 and 8e2acc0

@remicollet remicollet closed this May 19, 2025
@remicollet remicollet deleted the issue-ldapglobalopt branch May 19, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees
No one assigned
Labels
Extension: ldap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remicollet @Girgias