Promote warnings to errors in dir stdlib extension #4643
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm hesitating because TypeError doesn't necessarily feel right ... it's type is "resource", it has the correct "type" but is the wrong "stream resource type" ... Anyone else got words ? |
I wasn't sure myself, if the consensus is to change it to an Error I'll do that. |
|
We also use TypeError for incorrect resource types (like expected stream resource got mysqli resource). This seems similar enough to that to me. |
|
Merged as b3d7252 Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings changed:
"%d is not a valid Directory resource"promoted to TypeError"Directory name cannot be empty"promoted to Error