-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add CapabilityBoundingSet to systemd unit file #4960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This looks fine and I wouldn't hesitate too long before putting it in 7.4(.1) again like this |
@@ -32,6 +32,9 @@ NoNewPrivileges=true | |||
# but no physical devices such as /dev/sda. | |||
PrivateDevices=true | |||
|
|||
# Required for dropping privileges for running as a different user and changin owner and root. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Required for dropping privileges for running as a different user and changin owner and root. | |
# Required for dropping privileges for running as a different user and changing owner and root. |
Actually - CAP_KILL is also required for workers that run under a different user for |
I think at this point it's better to just not add this. |
@nikic I disagree, are you afraid there will be many more bug-reports caused by this more secure-by-default setup? Maybe documenting this in the Migrating-to-7.4 docs with possibly a link to How to find out what linux capabilities a process requires to work? is a better method of preventing that? |
This won't go to 7.4. It's just for master. |
@bukka What's the state here? |
I have got this on my list and will eventually pick it up. |
Re-introduced CapabilityBoundingSet that got removed in 7.4: 67cd427 as it was breaking apps. It looks that chroot has been also omitted and it needs to be verified again what is actually needed by FPM. As such this targets master only.
Any feedback for additional capabilities is welcome.