Move isinf, isnan, and isfinite to zend_portability.h #4966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not exactly sure how I am meant to indent it. |
nikic
approved these changes
Dec 5, 2019
| @@ -442,6 +442,20 @@ char *alloca(); | |||
|
|
|||
| #define ZEND_NAN NAN | |||
|
|
|||
| #if defined(__cplusplus) && __cplusplus >= 201103L | |||
| extern "C++" { | |||
There was a problem hiding this comment.
The extern block shouldn't be indented.
| # define zend_isnan std::isnan | ||
| # define zend_isinf std::isinf | ||
| # define zend_finite std::isfinite | ||
| } |
There was a problem hiding this comment.
For clarity, it's better to put the } right after the include, not the defines.
Should I add a comment to look into it again? Or should I try removing it altogether? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #4964