Explicitly declare the char as signed in zend_ffi_val. #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Girgias wants to merge 1 commit into php:master from Girgias:ffi-explicit-unsigned-char

ext/ffi/php_ffi.h

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -198,7 +198,7 @@ typedef struct _zend_ffi_val {
  
    		uint64_t        u64;

    		int64_t         i64;

    		zend_ffi_double d;

    		char            ch;

    		signed char     ch;

    		struct {

    			const char *str;

    			size_t      len;