Skip to content

Fixed run-tests.php for PHP 7.2 #5444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixed run-tests.php for PHP 7.2 #5444

wants to merge 2 commits into from

Conversation

flavioheleno
Copy link
Contributor

@flavioheleno flavioheleno commented Apr 24, 2020 •
edited
Loading

This PR fixes a syntax error in run-tests.php when executed using PHP 7.2 series.

The error:

$ php -v
PHP 7.2.29 (cli) (built: Apr 23 2020 22:10:25) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
$ php -lf run-tests.php 
PHP Parse error:  syntax error, unexpected '"', expecting '-' or identifier (T_STRING) or variable (T_VARIABLE) or number (T_NUM_STRING) in run-tests.php on line 2786

Parse error: syntax error, unexpected '"', expecting '-' or identifier (T_STRING) or variable (T_VARIABLE) or number (T_NUM_STRING) in run-tests.php on line 2786
Errors parsing run-tests.php

@flavioheleno flavioheleno mentioned this pull request Apr 24, 2020
Closed
nikic
nikic reviewed Apr 24, 2020
View reviewed changes
@flavioheleno
Actual fix for run-tests.php
80d2ecf 
Thanks @nikic for the review!
@php-pulls php-pulls closed this in 1baa583 Apr 27, 2020
@flavioheleno flavioheleno deleted the fix/run-tests branch April 28, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flavioheleno @nikic