Skip to content

Generate function entries for ext/zip #5601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kocsismate
Copy link
Member

No description provided.

@kocsismate kocsismate requested a review from remicollet May 20, 2020 10:09
Copy link
Member

@remicollet remicollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@php-pulls php-pulls closed this in 86d58e9 May 20, 2020
@kocsismate kocsismate deleted the function-entries-from-stubs2 branch May 20, 2020 12:34
@kocsismate
Copy link
Member Author

kocsismate commented May 20, 2020

@remicollet Slightly unrelated question: What do you think how we could eliminate resources from ext/zip's procedural interface? Could these functions be migrated to consume ZipArchive instances instead? Or would it make sense to deprecate the procedural interface altogether? Or you'd prefer using business-as-usual opaque objects?

@remicollet
Copy link
Member

@kocsismate sorry, have missed your question.

Indeed, I think we should rather deprecate the old procedual API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants