-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add some ValueErrors to ext/date #5613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
68f47b6
Add some ValueErrors to ext/date
Girgias 1e3509b
Fix null byte comment
Girgias b6fea36
Fix stubs/arginfo
Girgias 6f8f866
Make notice in timezone_identifiers_list() into a ValueError
Girgias 48240d5
Add warnings for when Epoch doesn't fit in a PHP integer
Girgias 2e24885
Make epoch doesn't fit into PHP String a value error for date_timesta…
Girgias aa48d8e
Drop todo comment because it's impossible to find the new link to sai…
Girgias 4f9cae2
Drop comment and rename error1 var
Girgias 9362d5a
Revert idate() changes
Girgias a72f3cb
Fix OpCache
Girgias 52593f5
Fix 32bit tests
Girgias File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,7 +73,7 @@ function date_isodate_set(DateTime $object, int $year, int $week, int $day = 1): | |
|
||
function date_timestamp_set(DateTime $object, int $timestamp): DateTime {} | ||
|
||
function date_timestamp_get(DateTimeInterface $object): int|false {} | ||
function date_timestamp_get(DateTimeInterface $object): int {} | ||
derickr marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
function timezone_open(string $timezone): DateTimeZone|false {} | ||
|
||
|
@@ -88,7 +88,7 @@ function timezone_transitions_get( | |
|
||
function timezone_location_get(DateTimeZone $object): array|false {} | ||
|
||
function timezone_identifiers_list(int $timezoneGroup = DateTimeZone::ALL, ?string $countryCode = null): array|false {} | ||
function timezone_identifiers_list(int $timezoneGroup = DateTimeZone::ALL, ?string $countryCode = null): array {} | ||
|
||
function timezone_abbreviations_list(): array {} | ||
|
||
|
@@ -230,7 +230,7 @@ public function setISODate(int $year, int $week, int $dayOfWeek = 1) {} | |
public function setTimestamp(int $timestamp) {} | ||
|
||
/** | ||
* @return int|false | ||
* @return int | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now it returns just an "int", can it not be set as a return type on the function (line 236) itself? |
||
* @alias date_timestamp_get | ||
*/ | ||
public function getTimestamp() {} | ||
|
@@ -282,7 +282,7 @@ public function getTimezone() {} | |
public function getOffset() {} | ||
|
||
/** | ||
* @return int|false | ||
* @return int | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto |
||
* @alias date_timestamp_get | ||
*/ | ||
public function getTimestamp() {} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: don't remove this empty line