Promote warning to exception in ext/sysvsem #6013
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
|
I'm unsure about this one. |
|
@nikic What's the problem with this one? Isn't it somewhat similar to the cases when we throw if a connection is not open? Or there are use-cases when people (have to) call |
|
This seems a bit different. It's not about being not open / uninitialized, but about performing an unlock without a lock. Best analogy to other extensions we have would probably be to commit/rollback without starting a transaction. Then again, unlock without lock does seem like a clear programming error... |
|
In case of doubt, then the best we can do is to close the PR :) It not a big waste. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.