Skip to content

Fix UNKNOWN default values in stubs #6075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Fix UNKNOWN default values in stubs #6075

wants to merge 4 commits into from

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Sep 4, 2020 •
edited
Loading

This is probably the last similar large scale PR. :)

cmb69
cmb69 reviewed Sep 4, 2020
View reviewed changes
nikic
nikic reviewed Sep 4, 2020
View reviewed changes
@kocsismate kocsismate force-pushed the unknown-default2 branch 2 times, most recently from 85e6d4d to c1d1c7a Compare September 4, 2020 16:51
nikic
nikic reviewed Sep 7, 2020
View reviewed changes
@php-pulls php-pulls closed this in 628db3f Sep 7, 2020
@kocsismate kocsismate deleted the unknown-default2 branch September 7, 2020 17:07
@kocsismate
Copy link
Member Author

Now, we only have around 50 UNKNOWN default values, excluding the ones being fixed by open PRs, and the ones in ext/dba and ext/imap :) I think there is just a handful of UNKNOWN defaults left to fix, mainly in ext/ldap and ext/odbc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kocsismate @nikic @cmb69