Make null byte error a ValueError #6094
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
force-pushed
the
null-byte-value-error
branch
from
bf9b4cc to
227988d
Compare
|
Makes perfect sense to me (slightly harder for the docs, but that shouldn't be a stopper). |
nikic
force-pushed
the
null-byte-value-error
branch
from
227988d to
b4ba43c
Compare
|
LGTM, this would allow us to use the PATH ZPP check in more place as before the usage of |
And don't replace trailing --CLEAN-- sections.
nikic
force-pushed
the
null-byte-value-error
branch
from
b4ba43c to
92059ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we treat paths with null bytes as a TypeError, which is semantically an odd choice, especially as we treat empty paths as ValueError. We do this because the error is generated by zpp and it's easier to always throw TypeError there.
This changes the zpp implementation to throw a TypeError only if the type is actually wrong and throw ValueError for null bytes. The error message is also split accordingly, to be more precise.
Test updates here are very much WIP.