Skip to content

Make argument type error message consistent for variadics #6101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nikic
Copy link
Member

@nikic nikic commented Sep 9, 2020

If an argument error refers to a variadic argument, we normally
do not print the name of the variadic (as it is not referring to
an individual argument, but to the collection of all of them).
However, this was not the case for the userland argument type
error message, which did it's own formatting.

If an argument error refers to a variadic argument, we normally
do not print the name of the variadic (as it is not referring to
an individual argument, but to the collection of all of them).
However, this was not the case for the userland argument type
error message, which did it's own formatting.
@nikic
Copy link
Member Author

nikic commented Sep 9, 2020

@kocsismate This is the intended behavior, right?

@kocsismate
Copy link
Member

@nikic TBH I like that variadic parameter names are displayed, just if all the passed variadic arguments would have the same name :) But the option you've just implemented makes sense for sure, consistency seems more important.

@php-pulls php-pulls closed this in b7fe1b6 Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants