Bcmath warning to error promotions #6105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
nikic
reviewed
Sep 11, 2020
This reverts commit 71e8769a4c059da5dfd6632825858f12c88d2346.
Girgias
force-pushed
the
bcmath-warning-to-error
branch
from
5426c0b to
ba4109e
Compare
nikic
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't go with promoting
php_error_docref(NULL, E_WARNING, "bcmath function argument is not well-formed");just yet as it would require wrapping all the calls tophp_str2num()in an if/else and changing it's return type from void to zend_result, which seems a bit like a hassle but I could do it if required.@nikic @kocsismate