Clean up ext/session errors #6111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Sep 10, 2020
71 tasks
kocsismate
force-pushed
the
session-callback
branch
from
f8e1d98 to
c74573f
Compare
nikic
reviewed
Sep 11, 2020
|
Some of those error conditions can likely be promoted. But I guess it's hard to say which for this extension. |
|
@nikic Yeah, I didn't do much promotions exactly because of this reason :( I think the cases could be promoted when a session is not active. The other issues with session handling (e.g. headers are already sent or session is already active) seem too disruptive for a promotion. |
kocsismate
commented
Sep 11, 2020
kocsismate
force-pushed
the
session-callback
branch
from
64fb267 to
7fac5fc
Compare
nikic
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, ext/session has the most typos and grammatical errors in its error messages among all the extensions.