Sqlite3 uninitialized object as error #6113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is our general stance regarding extensions which allow to choose an exception/error mode ( |
|
@cmb69 Always throw for this case. |
nikic
reviewed
Sep 11, 2020
ext/sqlite3/tests/bug66550.phpt
Outdated
| --EXPECTF-- | ||
| Warning: SQLite3Stmt::reset(): The SQLite3 object has not been correctly initialised in %s | ||
| --EXPECT-- | ||
| The SQLite3 object has not been correctly initialised |
There was a problem hiding this comment.
This message doesn't match the test well. I would at least add or already closed to it.
Test is borked if the posix_geteui() function is unavailable.
Girgias
force-pushed
the
sqlite3-uninitialized-error
branch
from
0cf1923 to
1d7b0f3
Compare
nikic
approved these changes
Sep 12, 2020
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cmb69 (as IIRC you are the maintainer) and @nikic (should I change the wording?)