Adjust ext/openssl parameter names #6121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Sep 12, 2020
bukka
reviewed
Sep 13, 2020
bukka
reviewed
Sep 13, 2020
kocsismate
force-pushed
the
openssl-renames
branch
from
7a8d6ad to
c99dcd2
Compare
65 tasks
|
@bukka This PR should be merged today, before beta 4 is tagged, so that we avoid exposing the previous buggy parameter names. Can you please recheck the PR? |
|
LGTM This is more a generic things and not for this PR but would be really nice if those stubs could be split to multiple lines. Those super long lines really suck... :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.