Skip to content

Pr/5803 #6122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

Pr/5803 #6122

wants to merge 16 commits into from

Conversation

kamil-tekiela
Copy link
Member

Switched warnings to exceptions for:

  • mysqli_data_seek
  • mysqli_fetch_field_direct
  • mysqli_field_seek
  • mysqli_num_rows

@kocsismate
Copy link
Member

kocsismate commented Sep 13, 2020 •
edited
Loading

@kamil-tekiela It would be much better if you could start your branch from master, not from George's PR.

UPDATE: Although, most probably you based your work on the existing PR in order to avoid conflicts and be able to use the ERROR_ARG_POS() macro.

@kamil-tekiela
Reverting back earlier changes.
cdc7d84 
After GitHub discussion I came to conclusion that it is better to let the function fail silently rather than throw an error.
`mysqli_fetch_field_direct` is used mostly with `SELECT *`. In my opinion an exception would still be smart choice but it might not be the right time for this change.
@Girgias
Copy link
Member

Girgias commented Sep 15, 2020

Can you rebase now that I've merged #5803 ?

@kamil-tekiela kamil-tekiela deleted the pr/5803 branch September 15, 2020 17:50
@kamil-tekiela
Copy link
Member Author

PR recreated under #6137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamil-tekiela @kocsismate @Girgias