Convert Division by 0 warnings to Error per the Engine Warning RFC #6125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 tasks
nikic
reviewed
Sep 13, 2020
Girgias
force-pushed
the
zend-warning-to-error
branch
from
e030f6a to
0d4c6a1
Compare
nikic
approved these changes
Sep 14, 2020
|
Also, weird that I completely missed this... Guess I wanted to add fdiv() first, but then forgot about the rest :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Zend/tests/bug76667.phpt is segfaulting in some instances, @nikic am I taking a wrong approach with how to implement this?