ext/soap: Compare Set-Cookie header case-insensitively #6143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polarina
force-pushed
the
php-7.3-soap-cookie
branch
from
ee0c09d to
9f06ea2
Compare
|
Implementation looks reasonable to me. Is there a sensible way to test this (without accessing a remote server)? |
|
@nikic I didn't see any existing tests in the For what it's worth, I compiled and deployed an updated |
nikic
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the SOAP server sends HTTP headers in all-lowercase, the SoapClient does not recognize the
set-cookieheader and skips over it.Fix this by searching for the
Set-Cookieheader in a case-insensitive manner.