Test IMAP on Azure #6162
Closed
Test IMAP on Azure #6162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Sep 18, 2020
azure/configure.yml
Outdated
| @@ -60,5 +60,6 @@ steps: | |||
| --with-unixODBC \ | |||
| --enable-werror \ | |||
| --with-config-file-path=/etc \ | |||
| --with-config-file-scan-dir=/etc/php.d | |||
| --with-config-file-scan-dir=/etc/php.d \ | |||
| --with-imap --with-kerberos --with-imap-ssl | |||
There was a problem hiding this comment.
Please move these before --enable-werror and one per line.
| @@ -2,13 +2,13 @@ | |||
| extension_loaded('imap') or die('skip imap extension not available in this build'); | |||
|
|
|||
| // Change these to make tests run successfully | |||
| $mailbox = '{localhost/norsh}'; | |||
| $mailbox = '{127.0.0.1:143/debug/norsh}'; | |||
There was a problem hiding this comment.
I used it to debug the connection locally and I think it would be rather useful to leave it on
ext/imap/tests/skipif.inc
Outdated
| $username = '[email protected]'; | ||
| $password = 'p4ssw0rd'; | ||
| $options = OP_HALFOPEN; // this should be enough to verify server present | ||
| $retries = 0; // don't retry connect on failure | ||
|
|
||
| $mbox = @imap_open($mailbox, $username, $password, $options, $retries); | ||
| $mbox = imap_open($mailbox, $username, $password, $options, $retries); |
There was a problem hiding this comment.
Suppression needs to stay here, otherwise SKIPIF will break.
There was a problem hiding this comment.
Forgot to revert while I was debugging the connection
Drop various ZPP checks and make them PASS Add CONFLICT file as the tests all hit the same mailbox
Girgias
force-pushed
the
imap-set-up-ci
branch
from
cc61664 to
0824b30
Compare
nikic
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took me a while but this should build and test the IMAP extension on Azure Pipelines.