Skip to content

Promote count() warning to TypeError #6180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Promote count() warning to TypeError #6180

wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Sep 21, 2020

One again, I removed a couple of tests which seems redundant (and also were a pain to update).

nikic
nikic reviewed Sep 21, 2020
View reviewed changes
nikic
nikic approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to rerun zend_vm_gen.php.

@php-pulls php-pulls closed this in 2ee7e29 Sep 21, 2020
@Girgias Girgias deleted the count-type-error branch September 21, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @nikic