Skip to content

Fix #64060: Test lstat_stat_variation7 incorrectly fails on certain f… #6194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Sep 23, 2020

…ile systems


As suggested by the OP.

@nikic
Copy link
Member

nikic commented Sep 25, 2020

Oh, interesting! Could you please try reverting 6aa6d70 and temporarily drop

if: type = cron
to test on arm64? It looks like I "fixed" this failure the wrong way.

@cmb69
Copy link
Member Author

cmb69 commented Sep 25, 2020

@nikic
Copy link
Member

nikic commented Sep 25, 2020

Hum okay. I guess adding the fclose() is still good practice to ensure everything is flushed, even though it probably doesn't matter anymore if blocks is no longer checked.

@php-pulls php-pulls closed this in 54435c9 Oct 2, 2020
@cmb69 cmb69 deleted the cmb/64060 branch October 2, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants