Fix #22986: odbc_connect() may reuse persistent connection #6223
+10
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`odbc_connect()` should not reuse persistent connections, since that prohibits multiple concurrent connections, which are occasionally desireable. We fix that by no longer looking for already cached connections when `odbc_connect()` is called, and instead creating a new connection instead.
nikic
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
This kind of non-persistent connection reuse is present in a couple of DB extensions. I remember fighting with it in the now removed interbase driver. The whole concept seems a leftover from times immemorial, where people were incapable of opening a connection once and passing it down to where it is needed... So yes, let's get rid of it, especially if it breaks other use-cases.
Can't comment on the crashing comment though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
odbc_connect()should not reuse persistent connections, since thatprohibits multiple concurrent connections, which are occasionally
desireable. We fix that by no longer looking for already cached
connections when
odbc_connect()is called, and instead creating a newconnection instead.
I'm slightly concerned about Shane's comment that there would be segfaults in case of multiple connections. I haven't found issues during quick testing, so maybe these have long been resolved. If we want to play it safe, we may postpone this to PHP 8.1, to have a longer QA cycle.