Skip to content

Removed broken php_url_encode_hash macro #6253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

patrickallaert
Copy link
Contributor

Broken since ~15 years ago (2994c23)

The macro calls php_url_encode_hash_ex() with 2 missing arguments and couldn't possibly be used since PHP 5.1.2.

@Girgias
Copy link
Member

Girgias commented Oct 1, 2020

This is an ABI break from my understanding and as RC1 has been tagged this will need approval from the Release Managers

@patrickallaert
Copy link
Contributor Author

This is an ABI break from my understanding and as RC1 has been tagged this will need approval from the Release Managers

This is a macro, not a function, there is no ABI break.

@carusogabriel carusogabriel requested a review from nikic October 1, 2020 17:21
@@ -25,6 +25,5 @@ PHPAPI void php_url_encode_hash_ex(HashTable *ht, smart_str *formstr,
const char *key_prefix, size_t key_prefix_len,
const char *key_suffix, size_t key_suffix_len,
zval *type, const char *arg_sep, int enc_type);
#define php_url_encode_hash(ht, formstr) php_url_encode_hash_ex((ht), (formstr), NULL, 0, NULL, 0, NULL, 0, NULL)
Copy link
Contributor

@carusogabriel carusogabriel Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this related to

/* {{{ php_url_encode_hash */
PHPAPI void php_url_encode_hash_ex(HashTable *ht, smart_str *formstr,
const char *num_prefix, size_t num_prefix_len,
const char *key_prefix, size_t key_prefix_len,
const char *key_suffix, size_t key_suffix_len,
zval *type, const char *arg_sep, int enc_type)
{
? If related at all, of course

@nikic nikic added this to the PHP 8.1 milestone Oct 2, 2020
@nikic
Copy link
Member

nikic commented Oct 2, 2020

This should be perfectly safe to remove, but it's also not exactly urgent so let's just merge it into PHP 8.1. I'll do so as soon as we have a branch.

@php-pulls php-pulls closed this in 15a92e8 Oct 9, 2020
@patrickallaert patrickallaert deleted the remove-broken-php_url_encode_hash branch October 30, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants